Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Issue 3404018: Add a TouchFile function that operates on FilePaths + fixing a bug... (Closed)

Created:
10 years, 3 months ago by dumi
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Paweł Hajdan Jr., pam+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Add a TouchFile function that operates on FilePaths + fixing a bug related to FILE_WRITE_ATTRIBUTES on Windows. BUG=none TEST=FileUtilTest::TouchFile Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60322

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -24 lines) Patch
M base/file_util.h View 2 chunks +7 lines, -2 lines 0 comments Download
M base/file_util.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M base/file_util_posix.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M base/file_util_unittest.cc View 2 chunks +13 lines, -3 lines 0 comments Download
M base/file_util_win.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M base/platform_file_posix.cc View 1 chunk +2 lines, -1 line 0 comments Download
M base/platform_file_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dumi
10 years, 3 months ago (2010-09-23 05:54:01 UTC) #1
darin (slow to review)
10 years, 3 months ago (2010-09-23 18:11:38 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698