Support additional webkit accessibility notifications and states.

Support additional webkit accessibility notifications and states. 

1. Update WebAccessibility::ConvertState to function similarly to WebCore's AccessibleBase::get_accState. 
2. Use WebKit's load complete notification to send the renderer's tree to the browser. 
We enable accessibility on the renderer now instead of requesting a tree. 
3. Use WebKit's focused ui element notification to send renderer focus events to the browser. 

BUG=13291
BUG=38106
TEST=interactive_ui_tests:AccessibilityWinBrowserTest.TestNotificationActiveDescendantChanged 
TEST=interactive_ui_tests:AccessibilityWinBrowserTest.TestNotificationFocusChanged 


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60569

[Chris Guillory, 2010-09-21 04:58:18]

Ready for review.

WebKit side patch is on this bug:
https://bugs.webkit.org/show_bug.cgi?id=45156

[dmazzoni, 2010-09-21 19:29:47]

LGTM aside from two things and the inline comments below:

1. Let's use a new flag to turn on renderer accessibility rather than reusing
the flag that's used to enable web accessibility in the browser process.

2. Have someone familiar with the renderer process-starting code okay the new
flag and that part of the change.

http://codereview.chromium.org/3380017/diff/22001/23001
File chrome/browser/accessibility_win_browsertest.cc (right):

http://codereview.chromium.org/3380017/diff/22001/23001#newcode376
chrome/browser/accessibility_win_browsertest.cc:376: GURL
tree_url("data:text/html,<ul aria-help='ul' tabindex='-1' role="
Same here, something other than aria-help

http://codereview.chromium.org/3380017/diff/22001/23001#newcode483
chrome/browser/accessibility_win_browsertest.cc:483: "data:text/html,<div
aria-help='div' tabindex='-1'></div>");
aria-help isn't in the spec, maybe use a tag that is in the spec to be more
clear

http://codereview.chromium.org/3380017/diff/22001/23017
File chrome/browser/renderer_host/render_widget_host_view_win.cc (right):

http://codereview.chromium.org/3380017/diff/22001/23017#newcode1488
chrome/browser/renderer_host/render_widget_host_view_win.cc:1488: new
BrowserAccessibilityManager(m_hWnd, empty_document, this));
indent 4 spaces yhere

http://codereview.chromium.org/3380017/diff/22001/23021
File chrome/renderer/render_view.cc (right):

http://codereview.chromium.org/3380017/diff/22001/23021#newcode4412
chrome/renderer/render_view.cc:4412: // Start renderer accessibility by
simulating a load complete notification.
What do you mean by "Start renderer accessibility"?

I'd maybe say "Since the webview is already loaded, initialize the browser's
cached accessibility tree by sending it a 'load complete' notification", or
something like that.

[Chris Guillory, 2010-09-21 23:18:04]

Now using --enable-accessibility.

http://codereview.chromium.org/3380017/diff/22001/23001
File chrome/browser/accessibility_win_browsertest.cc (right):

http://codereview.chromium.org/3380017/diff/22001/23001#newcode376
chrome/browser/accessibility_win_browsertest.cc:376: GURL
tree_url("data:text/html,<ul aria-help='ul' tabindex='-1' role="
On 2010/09/21 19:29:49, Dominic Mazzoni wrote:
> Same here, something other than aria-help

Done.

http://codereview.chromium.org/3380017/diff/22001/23001#newcode483
chrome/browser/accessibility_win_browsertest.cc:483: "data:text/html,<div
aria-help='div' tabindex='-1'></div>");
On 2010/09/21 19:29:49, Dominic Mazzoni wrote:
> aria-help isn't in the spec, maybe use a tag that is in the spec to be more
> clear

Done. Having an aria role is sufficient for keeping the node from being pruned
from the accessibility tree.

http://codereview.chromium.org/3380017/diff/22001/23017
File chrome/browser/renderer_host/render_widget_host_view_win.cc (right):

http://codereview.chromium.org/3380017/diff/22001/23017#newcode1488
chrome/browser/renderer_host/render_widget_host_view_win.cc:1488: new
BrowserAccessibilityManager(m_hWnd, empty_document, this));
On 2010/09/21 19:29:49, Dominic Mazzoni wrote:
> indent 4 spaces yhere

Done.

http://codereview.chromium.org/3380017/diff/22001/23021
File chrome/renderer/render_view.cc (right):

http://codereview.chromium.org/3380017/diff/22001/23021#newcode4412
chrome/renderer/render_view.cc:4412: // Start renderer accessibility by
simulating a load complete notification.
On 2010/09/21 19:29:49, Dominic Mazzoni wrote:
> What do you mean by "Start renderer accessibility"?
> 
> I'd maybe say "Since the webview is already loaded, initialize the browser's
> cached accessibility tree by sending it a 'load complete' notification", or
> something like that.
> 

Done.

[Chris Guillory, 2010-09-22 00:05:35]

> 2. Have someone familiar with the renderer process-starting code okay the new
> flag and that part of the change.
Jam, could you look at the new renderer command line parameter
--enable-accessibility. In chrome_switches.h/cc,
browser_render_process_host.h/cc, and render_view.h/cc?

[jam, 2010-09-24 18:00:45]

On 2010/09/22 00:05:35, Chris Guillory wrote:
> > 2. Have someone familiar with the renderer process-starting code okay the
new
> > flag and that part of the change.
> Jam, could you look at the new renderer command line parameter
> --enable-accessibility. In chrome_switches.h/cc,
> browser_render_process_host.h/cc, and render_view.h/cc?

lgtm