Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1222)

Unified Diff: src/x64/fast-codegen-x64.cc

Issue 337060: Factor out a commonly used code sequence to DropAndMove(Location, Register) (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ia32/fast-codegen-ia32.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/x64/fast-codegen-x64.cc
===================================================================
--- src/x64/fast-codegen-x64.cc (revision 3152)
+++ src/x64/fast-codegen-x64.cc (working copy)
@@ -149,6 +149,18 @@
}
+void FastCodeGenerator::DropAndMove(Location destination, Register source) {
+ switch (destination.type()) {
+ case Location::NOWHERE:
+ __ addq(rsp, Immediate(kPointerSize));
+ break;
+ case Location::TEMP:
+ __ movq(Operand(rsp, 0), source);
+ break;
+ }
+}
+
+
void FastCodeGenerator::DeclareGlobals(Handle<FixedArray> pairs) {
// Call the runtime to declare the globals.
__ push(rsi); // The context is the first argument.
@@ -226,16 +238,7 @@
// A test rax instruction following the call is used by the IC to
// indicate that the inobject property case was inlined. Ensure there
// is no test rax instruction here.
- switch (expr->location().type()) {
- case Location::NOWHERE:
- __ addq(rsp, Immediate(kPointerSize));
- break;
- case Location::TEMP:
- // Replace the global object with the result.
- __ movq(Operand(rsp, 0), rax);
- break;
- }
-
+ DropAndMove(expr->location(), rax);
} else {
Comment cmnt(masm_, "Stack slot");
Move(expr->location(), rewrite->AsSlot());
@@ -468,14 +471,7 @@
Handle<Code> ic(Builtins::builtin(Builtins::StoreIC_Initialize));
__ Call(ic, RelocInfo::CODE_TARGET);
// Overwrite the global object on the stack with the result if needed.
- switch (expr->location().type()) {
- case Location::NOWHERE:
- __ addq(rsp, Immediate(kPointerSize));
- break;
- case Location::TEMP:
- __ movq(Operand(rsp, 0), rax);
- break;
- }
+ DropAndMove(expr->location(), rax);
} else {
// Local or parameter assignment.
@@ -570,14 +566,7 @@
// Restore context register.
__ movq(rsi, Operand(rbp, StandardFrameConstants::kContextOffset));
// Discard the function left on TOS.
- switch (expr->location().type()) {
- case Location::NOWHERE:
- __ addq(rsp, Immediate(kPointerSize));
- break;
- case Location::TEMP:
- __ movq(Operand(rsp, 0), rax);
- break;
- }
+ DropAndMove(expr->location(), rax);
}
@@ -617,14 +606,7 @@
__ Call(construct_builtin, RelocInfo::CONSTRUCT_CALL);
// Replace function on TOS with result in rax, or pop it.
- switch (node->location().type()) {
- case Location::TEMP:
- __ movq(Operand(rsp, 0), rax);
- break;
- case Location::NOWHERE:
- __ addq(rsp, Immediate(kPointerSize));
- break;
- }
+ DropAndMove(node->location(), rax);
}
« no previous file with comments | « src/ia32/fast-codegen-ia32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698