Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Unified Diff: src/ia32/fast-codegen-ia32.cc

Issue 337060: Factor out a commonly used code sequence to DropAndMove(Location, Register) (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/fast-codegen.h ('k') | src/x64/fast-codegen-x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ia32/fast-codegen-ia32.cc
===================================================================
--- src/ia32/fast-codegen-ia32.cc (revision 3152)
+++ src/ia32/fast-codegen-ia32.cc (working copy)
@@ -141,6 +141,18 @@
}
+void FastCodeGenerator::DropAndMove(Location destination, Register source) {
+ switch (destination.type()) {
+ case Location::NOWHERE:
+ __ add(Operand(esp), Immediate(kPointerSize));
+ break;
+ case Location::TEMP:
+ __ mov(Operand(esp, 0), source);
+ break;
+ }
+}
+
+
void FastCodeGenerator::DeclareGlobals(Handle<FixedArray> pairs) {
// Call the runtime to declare the globals.
__ push(esi); // The context is the first argument.
@@ -211,16 +223,7 @@
// (eg, push/pop elimination).
__ nop();
- switch (expr->location().type()) {
- case Location::NOWHERE:
- __ add(Operand(esp), Immediate(kPointerSize));
- break;
- case Location::TEMP:
- // Replace the global object with the result.
- __ mov(Operand(esp, 0), eax);
- break;
- }
-
+ DropAndMove(expr->location(), eax);
} else {
Comment cmnt(masm_, "Stack slot");
Move(expr->location(), rewrite->AsSlot());
@@ -455,14 +458,7 @@
Handle<Code> ic(Builtins::builtin(Builtins::StoreIC_Initialize));
__ call(ic, RelocInfo::CODE_TARGET);
// Overwrite the global object on the stack with the result if needed.
- switch (expr->location().type()) {
- case Location::NOWHERE:
- __ add(Operand(esp), Immediate(kPointerSize));
- break;
- case Location::TEMP:
- __ mov(Operand(esp, 0), eax);
- break;
- }
+ DropAndMove(expr->location(), eax);
} else {
// Local or parameter assignment.
@@ -557,14 +553,7 @@
// Restore context register.
__ mov(esi, Operand(ebp, StandardFrameConstants::kContextOffset));
// Discard the function left on TOS.
- switch (expr->location().type()) {
- case Location::NOWHERE:
- __ add(Operand(esp), Immediate(kPointerSize));
- break;
- case Location::TEMP:
- __ mov(Operand(esp, 0), eax);
- break;
- }
+ DropAndMove(expr->location(), eax);
}
@@ -603,14 +592,7 @@
__ call(construct_builtin, RelocInfo::CONSTRUCT_CALL);
// Replace function on TOS with result in eax, or pop it.
- switch (node->location().type()) {
- case Location::TEMP:
- __ mov(Operand(esp, 0), eax);
- break;
- case Location::NOWHERE:
- __ add(Operand(esp), Immediate(kPointerSize));
- break;
- }
+ DropAndMove(node->location(), eax);
}
« no previous file with comments | « src/fast-codegen.h ('k') | src/x64/fast-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698