Issue 337054: Allow non-absolute arguments to --user-data-dir.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 337054: Allow non-absolute arguments to --user-data-dir. (Closed)

Created:
11 years, 1 month ago by Elliot Glaysher

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang, MAD, agl, Evan Martin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Make all paths passed to --user-data-dir absolute. BUG=24355 TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30284

Patch Set 1 #

Total comments: 1

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -8 lines)			Patch
	M	base/path_service.cc	View		1 chunk	+8 lines, -8 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

MAD

11 years, 1 month ago (2009-10-27 23:22:56 UTC) #5

LGTM with a small nit...

http://codereview.chromium.org/337054/diff/1/2
File base/path_service.cc (right):

http://codereview.chromium.org/337054/diff/1/2#newcode218
Line 218: // Make sure the directory exists. We need to do this before we make
"...before we make translate..."???
Is it just me or this could be worded better? :-)

Expand Messages | Collapse Messages