Allow non-absolute arguments to --user-data-dir.

base/path_service.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/path_service.h"
 
 #ifdef OS_WIN
 #include <windows.h>
 #include <shellapi.h>
 #include <shlobj.h>
@@ skipping 196 matching lines @@
   AutoLock scoped_lock(path_data->lock);
   return path_data->overrides.find(key) != path_data->overrides.end();
 }
 
 bool PathService::Override(int key, const FilePath& path) {
   PathData* path_data = GetPathData();
   DCHECK(path_data);
   DCHECK(key > base::DIR_CURRENT) << "invalid path key";
 
   FilePath file_path = path;
-#if defined(OS_WIN)
-  // On Windows we switch the current working directory to load plugins (at
-  // least). That's not the case on POSIX.
-  // Also, on POSIX, AbsolutePath fails if called on a non-existant path.
-  if (!file_util::AbsolutePath(&file_path))
-    return false;
-#endif
 
-  // make sure the directory exists:
+  // Make sure the directory exists. We need to do this before we make

[MAD, 2009/10/27 23:22:56]

"...before we make translate..."???
Is it just me or this could be worded better? :-)

+  // translate this to the absolute path because on POSIX, AbsolutePath fails
+  // if called on a non-existant path.
   if (!file_util::PathExists(file_path) &&
       !file_util::CreateDirectory(file_path))
     return false;
 
+  // We need to have an absolute path, as extensions and plugins don't like
+  // relative paths.
+  if (!file_util::AbsolutePath(&file_path))
+    return false;
+
   AutoLock scoped_lock(path_data->lock);
   path_data->cache[key] = file_path;
   path_data->overrides.insert(key);
   return true;
 }
 
 void PathService::RegisterProvider(ProviderFunc func, int key_start,
                                    int key_end) {
   PathData* path_data = GetPathData();
   DCHECK(path_data);
@@ skipping 15 matching lines @@
   p = new Provider;
   p->is_static = false;
   p->func = func;
   p->next = path_data->providers;
 #ifndef NDEBUG
   p->key_start = key_start;
   p->key_end = key_end;
 #endif
   path_data->providers = p;
 }