Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 337043: Let layout tests run on Windows 7. (Closed)

Created:
11 years, 1 month ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
ojan
CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org
Visibility:
Public.

Description

Let layout tests run on Windows 7. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30211

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M webkit/tools/test_shell/test_shell_platform_delegate_win.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
M-A Ruel
11 years, 1 month ago (2009-10-27 14:37:52 UTC) #1
ojan
LGTM. Do all the tests pass? On Tue, Oct 27, 2009 at 7:37 AM, <maruel@chromium.org> ...
11 years, 1 month ago (2009-10-27 16:01:50 UTC) #2
M-A Ruel
11 years, 1 month ago (2009-10-27 16:08:11 UTC) #3
On 2009/10/27 16:01:50, ojan wrote:
> LGTM. Do all the tests pass?

No but I won't be able to fix them if I can't even run them. :)

Powered by Google App Engine
This is Rietveld 408576698