Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 337032: Show status bubble for links that have keyboard focus.... (Closed)

Created:
11 years, 1 month ago by Evan Stade
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin (slow to review), jam
Visibility:
Public.

Description

Show status bubble for links that have keyboard focus. I tried to just piggy-back off of existing chrome client calls (particularly focus()), but that didn't handle blurs. webkit side is here: http://codereview.chromium.org/328034/show BUG=453

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -4 lines) Patch
M chrome/renderer/print_web_view_helper.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/render_view.h View 3 chunks +12 lines, -2 lines 0 comments Download
M chrome/renderer/render_view.cc View 2 chunks +13 lines, -2 lines 0 comments Download
M webkit/api/public/WebViewClient.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/glue/chrome_client_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/glue/chrome_client_impl.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Evan Stade
Ben, can you comment whether this behavior is desirable? I've heard multiple requests for this ...
11 years, 1 month ago (2009-10-26 22:26:36 UTC) #1
Ben Goodger (Google)
This happens only after you tab into a link, right? not justwhen you press down ...
11 years, 1 month ago (2009-10-27 05:09:05 UTC) #2
Evan Stade
+dglazkov for webkit side review On 2009/10/27 05:09:05, Ben Goodger wrote: > This happens only ...
11 years, 1 month ago (2009-10-27 18:35:56 UTC) #3
darin (slow to review)
11 years, 1 month ago (2009-10-27 19:24:56 UTC) #4
LGTM

Note: I just committed a change that moves chrome_client_impl.{h,cc} into
webkit/api/src

Powered by Google App Engine
This is Rietveld 408576698