Issue 337014: Add a CERT_RDN_ENCODED_BLOB case to CertSubjectCommonNameHasNull...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 337014: Add a CERT_RDN_ENCODED_BLOB case to CertSubjectCommonNameHasNull... (Closed)

Created:
11 years, 2 months ago by wtc

Modified:
9 years, 7 months ago

Reviewers:
rvargas (doing something else)

CC:
chromium-reviews_googlegroups.com, darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add a CERT_RDN_ENCODED_BLOB case to CertSubjectCommonNameHasNull because we get CERT_RDN_ENCODED_BLOB on machines patched for the CryptoAPI ASN.1 security vulnerabilities. R=rvargas BUG=24190 TEST=the X509CertificateTest.PaypalNullCertParsing test in net_unittests (debug build) should not hit a NOTREACHED() assertion failure when running on a patched Windows machine. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30057

Patch Set 1 #

Patch Set 2 : Improve comment #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	net/base/x509_certificate_win.cc	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages