Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: net/base/x509_certificate_win.cc

Issue 337014: Add a CERT_RDN_ENCODED_BLOB case to CertSubjectCommonNameHasNull... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Improve comment Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/x509_certificate_win.cc
===================================================================
--- net/base/x509_certificate_win.cc (revision 29830)
+++ net/base/x509_certificate_win.cc (working copy)
@@ -204,6 +204,12 @@
PCERT_RDN_ATTR rdn_attr = &rdn->rgRDNAttr[j];
if (strcmp(rdn_attr->pszObjId, szOID_COMMON_NAME) == 0) {
switch (rdn_attr->dwValueType) {
+ // After the CryptoAPI ASN.1 security vulnerabilities described in
+ // http://www.microsoft.com/technet/security/Bulletin/MS09-056.mspx
+ // were patched, we get CERT_RDN_ENCODED_BLOB for a common name
+ // that contains a NULL character.
+ case CERT_RDN_ENCODED_BLOB:
+ break;
// Array of 8-bit characters.
case CERT_RDN_PRINTABLE_STRING:
case CERT_RDN_TELETEX_STRING:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698