Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 3359013: Revert 58809 - Implement the webNavigation.onCommitted event.... (Closed)

Created:
10 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
9 years, 7 months ago
CC:
chromium-reviews, ben+cc_chromium.org, Erik does not do reviews, Paweł Hajdan Jr., Aaron Boodman, pam+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Revert 58809 - Implement the webNavigation.onCommitted event. BUG=50943 TEST=ExtensionApiTest.WebNavigationEvents Review URL: http://codereview.chromium.org/3369007 TBR=jochen@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58816

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -327 lines) Patch
D chrome/browser/extensions/extension_webnavigation_api.h View 1 chunk +0 lines, -56 lines 0 comments Download
D chrome/browser/extensions/extension_webnavigation_api.cc View 1 chunk +0 lines, -85 lines 0 comments Download
M chrome/browser/extensions/extension_webnavigation_apitest.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extensions_service.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/navigation_controller.cc View 3 chunks +0 lines, -9 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/extension_api.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/experimental.webNavigation.html View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/page_transition_types.h View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/common/page_transition_types.cc View 1 chunk +0 lines, -17 lines 0 comments Download
D chrome/test/data/extensions/api_test/webnavigation/navigation/clientRedirect/a.html View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/test/data/extensions/api_test/webnavigation/navigation/clientRedirect/b.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/extensions/api_test/webnavigation/navigation/forwardBack/a.html View 1 chunk +0 lines, -6 lines 0 comments Download
D chrome/test/data/extensions/api_test/webnavigation/navigation/forwardBack/b.html View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/test/data/extensions/api_test/webnavigation/navigation/iframe/a.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/extensions/api_test/webnavigation/navigation/iframe/b.html View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/test/data/extensions/api_test/webnavigation/navigation/iframe/c.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/extensions/api_test/webnavigation/navigation/manifest.json View 1 chunk +0 lines, -7 lines 0 comments Download
D chrome/test/data/extensions/api_test/webnavigation/navigation/simpleLoad/a.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/extensions/api_test/webnavigation/navigation/test.html View 1 chunk +0 lines, -113 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jochen (gone - plz use gerrit)
10 years, 3 months ago (2010-09-08 12:29:36 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698