Issue 3369007: Implement the webNavigation.onCommitted event.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3369007: Implement the webNavigation.onCommitted event. (Closed)

Created:
10 years, 3 months ago by jochen (gone - plz use gerrit)

Modified:
9 years, 7 months ago

Reviewers:

CC:
chromium-reviews, ben+cc_chromium.org, Erik does not do reviews, Paweł Hajdan Jr., Aaron Boodman, pam+watch_chromium.org, brettw-cc_chromium.org

Visibility:
Public.

Description

Implement the webNavigation.onCommitted event. BUG=50943 TEST=ExtensionApiTest.WebNavigationEvents Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58809

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+327 lines, -4 lines)			Patch
A	chrome/browser/extensions/extension_webnavigation_api.h	View	1 chunk	+56 lines, -0 lines	0 comments	Download
A	chrome/browser/extensions/extension_webnavigation_api.cc	View	1 chunk	+85 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_webnavigation_apitest.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extensions_service.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/navigation_controller.cc	View	3 chunks	+9 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/api/extension_api.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/docs/experimental.webNavigation.html	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/common/page_transition_types.h	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/common/page_transition_types.cc	View	1 chunk	+17 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/webnavigation/navigation/clientRedirect/a.html	View	1 chunk	+3 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/webnavigation/navigation/clientRedirect/b.html	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/webnavigation/navigation/forwardBack/a.html	View	1 chunk	+6 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/webnavigation/navigation/forwardBack/b.html	View	1 chunk	+3 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/webnavigation/navigation/iframe/a.html	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/webnavigation/navigation/iframe/b.html	View	1 chunk	+3 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/webnavigation/navigation/iframe/c.html	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/webnavigation/navigation/manifest.json	View	1 chunk	+7 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/webnavigation/navigation/simpleLoad/a.html	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/webnavigation/navigation/test.html	View	1 chunk	+113 lines, -0 lines	0 comments	Download