chrome/test/data/extensions/api_test/window_open/popup_blocking/hosted_app/manifest.json - Issue 3352009: Fix bug where window.open() with no feature string from

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/window_open/popup_blocking/hosted_app/manifest.json

Issue 3352009: Fix bug where window.open() with no feature string from (Closed) Base URL: git://codf21.jail/chromium.git

Patch Set: add license text Created 10 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/extensions/api_test/window_open/popup_blocking/extension/background.html ('K') | « chrome/test/data/extensions/api_test/window_open/popup_blocking/extension/tab.html ('k') | chrome/test/data/extensions/api_test/window_open/popup_blocking/hosted_app/open_popup.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/window_open/popup_blocking/hosted_app/manifest.json

diff --git a/chrome/test/data/extensions/api_test/window_open/popup_blocking/hosted_app/manifest.json b/chrome/test/data/extensions/api_test/window_open/popup_blocking/hosted_app/manifest.json

new file mode 100644

index 0000000000000000000000000000000000000000..342a33133ac93156c57b27a00b3a9fe2f083f47e

--- /dev/null

+++ b/chrome/test/data/extensions/api_test/window_open/popup_blocking/hosted_app/manifest.json

@@ -0,0 +1,13 @@

+ "name": "Popup blocking test",

+ "version": "1",

+ "description": "Popup windows should never be blocked from within a hosted app.",

+ "app": {

+ "urls": [

+ "http://a.com/"

+ ],

+ "launch": {

+ "web_url": "http://a.com/app.html"

+ }