Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 335044: Fix bug in test on Windows. (Closed)

Created:
11 years, 1 month ago by Lasse Reichstein
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix bug in test on Windows.

Patch Set 1 #

Patch Set 2 : And now the right fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/cctest/test-log-stack-tracer.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Lasse Reichstein
Tiny review.
11 years, 1 month ago (2009-10-27 13:16:07 UTC) #1
Søren Thygesen Gjesse
11 years, 1 month ago (2009-10-27 13:19:25 UTC) #2
LGTM,

consider sizeof(void*) as used in globals.h (requires // NOLINT though).

Powered by Google App Engine
This is Rietveld 408576698