Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Unified Diff: test/cctest/test-log-stack-tracer.cc

Issue 335044: Fix bug in test on Windows. (Closed)
Patch Set: And now the right fix. Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-log-stack-tracer.cc
diff --git a/test/cctest/test-log-stack-tracer.cc b/test/cctest/test-log-stack-tracer.cc
index 9905db82d8ef0fb7489568bcdb654f7b83b1c1ba..dadf7b9a3e1474fd45e042071297c0626d417bab 100644
--- a/test/cctest/test-log-stack-tracer.cc
+++ b/test/cctest/test-log-stack-tracer.cc
@@ -336,7 +336,7 @@ static void CFuncDoTrace(byte dummy_parameter) {
#elif defined _MSC_VER
// Approximate a frame pointer address. We compile without base pointers,
// so we can't trust ebp/rbp.
- fp = &dummy_parameter - 2 * kPointerSize;
+ fp = &dummy_parameter - 2 * sizeof(&dummy_parameter);
#else
#error Unexpected platform.
#endif
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698