Issue 335042: Revert 30149 - The existing file_util::AbsolutePath() function was already do...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 335042: Revert 30149 - The existing file_util::AbsolutePath() function was already do... (Closed)

Created:
11 years, 1 month ago by tim (not reviewing)

Modified:
9 years, 6 months ago

Reviewers:
MAD

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, Aaron Boodman, pam+watch_chromium.org, Erik does not do reviews, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Revert 30149 - The existing file_util::AbsolutePath() function was already doing what we needed to do in the ExtensionResource class. BUG= http://crbug.com/25681 & http://crbug.com/25131 Review URL: http://codereview.chromium.org/334028 TBR=mad@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30152

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+180 lines, -11 lines)			Patch
M	base/file_path.h	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	base/file_path.cc	View	1 chunk	+69 lines, -0 lines	0 comments	Download
M	base/file_path_unittest.cc	View	1 chunk	+92 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/extension_resource.cc	View	1 chunk	+7 lines, -11 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

MAD

11 years, 1 month ago (2009-10-27 02:37:06 UTC) #2

Working on it... :-(

BYE
MAD

On Mon, Oct 26, 2009 at 10:17 PM, <tim@chromium.org> wrote:

> Reviewers: mad1,
>
> Description:
> Revert 30149 - The existing file_util::AbsolutePath() function was already
> doing
> what we needed to do in the ExtensionResource class.
>
> BUG= http://crbug.com/25681 & http://crbug.com/25131
>
> Review URL: http://codereview.chromium.org/334028
>
> TBR=mad@chromium.org
>
> Please review this at http://codereview.chromium.org/335042
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     base/file_path.h
>  M     base/file_path.cc
>  M     base/file_path_unittest.cc
>  M     chrome/common/extensions/extension_resource.cc
>
>
>

Expand Messages | Collapse Messages