Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 335027: Reverted 3130-3131 since they don't work on mac. (Closed)

Created:
11 years, 1 month ago by Christian Plesner Hansen
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Reverted 3130-3131 since they don't work on mac. Committed: http://code.google.com/p/v8/source/detail?r=3133

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+499 lines, -1012 lines) Patch
M src/api.h View 1 chunk +0 lines, -9 lines 0 comments Download
M src/arm/codegen-arm.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M src/arm/frames-arm.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/frames-arm.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 4 chunks +9 lines, -10 lines 0 comments Download
M src/assembler.h View 2 chunks +0 lines, -8 lines 0 comments Download
M src/assembler.cc View 2 chunks +0 lines, -25 lines 0 comments Download
M src/code-stubs.h View 2 chunks +0 lines, -7 lines 0 comments Download
M src/code-stubs.cc View 2 chunks +14 lines, -34 lines 0 comments Download
M src/codegen.h View 2 chunks +1 line, -27 lines 0 comments Download
M src/codegen.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M src/frames.h View 4 chunks +22 lines, -1 line 0 comments Download
M src/frames.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M src/handles.h View 2 chunks +3 lines, -7 lines 0 comments Download
M src/handles.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 6 chunks +9 lines, -64 lines 0 comments Download
M src/ia32/frames-ia32.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/frames-ia32.cc View 1 chunk +6 lines, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.h View 3 chunks +2 lines, -10 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 5 chunks +16 lines, -79 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 1 chunk +10 lines, -29 lines 0 comments Download
M src/objects.h View 2 chunks +1 line, -3 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/runtime.cc View 2 chunks +0 lines, -13 lines 0 comments Download
M src/stub-cache.cc View 1 chunk +1 line, -6 lines 0 comments Download
M src/top.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/x64/codegen-x64.cc View 7 chunks +9 lines, -14 lines 0 comments Download
M src/x64/frames-x64.h View 1 chunk +1 line, -1 line 0 comments Download
src/x64/frames-x64.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 4 chunks +8 lines, -11 lines 0 comments Download
test/cctest/SConscript View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/cctest.h View 2 chunks +0 lines, -136 lines 0 comments Download
M test/cctest/cctest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
D test/cctest/test-accessors.cc View 1 chunk +0 lines, -424 lines 0 comments Download
M test/cctest/test-api.cc View 10 chunks +338 lines, -14 lines 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M test/cctest/test-log-stack-tracer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M test/mjsunit/fuzz-natives.js View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Christian Plesner Hansen
Bummer...
11 years, 1 month ago (2009-10-26 15:15:53 UTC) #1
Erik Corry
11 years, 1 month ago (2009-10-26 19:35:45 UTC) #2
LGTM.  It's probably the stack alignment.

Powered by Google App Engine
This is Rietveld 408576698