Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 3348010: Revert 58196 - GTTF: Clean up DownloadFileManager... (Closed)

Created:
10 years, 3 months ago by Paweł Hajdan Jr.
Modified:
9 years, 7 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, Paweł Hajdan Jr., ben+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Revert 58196 - GTTF: Clean up DownloadFileManager This removes a lot of duplication, locking, and thread jumping. Most of the operations run on the FILE thread, and we do not duplicate so much information. Each DownloadFile keeps track of its DownloadManager (each Profile has its own DownloadManager). This allows us to remove many maps from DownloadFileManager that were duplicating that information. There is still SaveFileManager, but hopefully I will be able to merge those two in small steps. TEST=unit_tests, browser_tests, ui_tests BUG=48913 Review URL: http://codereview.chromium.org/3245005 TBR=phajdan.jr@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58718

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -130 lines) Patch
M chrome/browser/download/base_file.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/download/base_file.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/download/base_file_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_file.h View 4 chunks +1 line, -10 lines 0 comments Download
M chrome/browser/download/download_file.cc View 2 chunks +2 lines, -16 lines 0 comments Download
M chrome/browser/download/download_file_manager.h View 4 chunks +35 lines, -11 lines 0 comments Download
M chrome/browser/download/download_file_manager.cc View 12 chunks +208 lines, -80 lines 0 comments Download
M chrome/browser/download/download_manager.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/download/download_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/save_file.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/download_resource_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Paweł Hajdan Jr.
10 years, 3 months ago (2010-09-07 17:58:09 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698