GTK: Activate window when "Get themes" button is clicked.

GTK: Activate window when "Get themes" button is clicked.

This is a direct copy of the Views fix from r29949.

BUG=24866
TESTED=verified that minimized browser window gets restored under metacity

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30286

[Evan Martin, 2009-10-27 18:02:05]

LGTM

http://codereview.chromium.org/334048/diff/1/2
File chrome/browser/gtk/options/content_page_gtk.cc (right):

http://codereview.chromium.org/334048/diff/1/2#newcode318
Line 318: browser->window()->Activate();
Maybe this should be refactored somehow?
Browser::OpenThemesGallery?

[Evan Martin, 2009-10-27 18:02:30]

On 2009/10/27 18:02:05, Evan Martin wrote:
> LGTM
> 
> http://codereview.chromium.org/334048/diff/1/2
> File chrome/browser/gtk/options/content_page_gtk.cc (right):
> 
> http://codereview.chromium.org/334048/diff/1/2#newcode318
> Line 318: browser->window()->Activate();
> Maybe this should be refactored somehow?
> Browser::OpenThemesGallery?

The more I think about this, the more I think it should be refactored, since
this fix will otherwise need to happen on Mac too.

[Daniel Erat, 2009-10-27 19:02:20]

On Tue, Oct 27, 2009 at 11:02 AM,  <evan@chromium.org> wrote:
> On 2009/10/27 18:02:05, Evan Martin wrote:
>>
>> LGTM
>
>> http://codereview.chromium.org/334048/diff/1/2
>> File chrome/browser/gtk/options/content_page_gtk.cc (right):
>
>> http://codereview.chromium.org/334048/diff/1/2#newcode318
>> Line 318: browser->window()->Activate();
>> Maybe this should be refactored somehow?
>> Browser::OpenThemesGallery?
>
> The more I think about this, the more I think it should be refactored, since
> this fix will otherwise need to happen on Mac too.

Okay, I will do my best to figure out enough of the Mac's moon man
language to share this code (their implementation seems a bit
different currently, presumably because Chrome can be running without
any browser windows currently open).

> http://codereview.chromium.org/334048
>

[Evan Martin, 2009-10-27 19:03:23]

I think you can just stick this code in a central location and file a bug for
the mac saying "check that this works, tweak the centralized function if not"

[tony, 2009-10-27 22:13:03]

On 2009/10/27 19:03:23, Evan Martin wrote:
> I think you can just stick this code in a central location and file a bug for
> the mac saying "check that this works, tweak the centralized function if not"

I tried this on a mac and I think it already works.

[Evan Martin, 2009-10-27 22:56:20]

Nice!  LGTM if you run it through the trybots.

[use derat at chromium.org, 2009-10-28 23:26:45]

On Tue, Oct 27, 2009 at 11:02 AM,  <evan@chromium.org> wrote:
> LGTM
>
>
> http://codereview.chromium.org/334048/diff/1/2
> File chrome/browser/gtk/options/content_page_gtk.cc (right):
>
> http://codereview.chromium.org/334048/diff/1/2#newcode318
> Line 318: browser->window()->Activate();
> Maybe this should be refactored somehow?
> Browser::OpenThemesGallery?

Done.  Another look?  (... and if you're feeling generous, a Windows
compile and test run?  I guess I should ask for a Windows machine
sometime. :-( )

> http://codereview.chromium.org/334048
>