Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 334046: DevTools: fix colors of heap snapshot summary bar. (Closed)

Created:
11 years, 1 month ago by mnaganov (inactive)
Modified:
9 years, 7 months ago
Reviewers:
pfeldman
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

DevTools: fix colors of heap snapshot summary bar. BUG=25927 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30197

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M webkit/glue/devtools/js/heap_profiler_panel.js View 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
mnaganov (inactive)
11 years, 1 month ago (2009-10-27 15:17:49 UTC) #1
pfeldman1
11 years, 1 month ago (2009-10-27 15:48:48 UTC) #2
LGTM

On Tue, Oct 27, 2009 at 6:17 PM,  <mnaganov@chromium.org> wrote:
> Reviewers: pfeldman,
>
> Description:
> DevTools: fix colors of heap snapshot summary bar.
>
> BUG=3D25927
> TEST=3Dnone
>
> Please review this at http://codereview.chromium.org/334046
>
> Affected files:
> =A0M webkit/glue/devtools/js/heap_profiler_panel.js
>
>
> Index: webkit/glue/devtools/js/heap_profiler_panel.js
> diff --git a/webkit/glue/devtools/js/heap_profiler_panel.js
> b/webkit/glue/devtools/js/heap_profiler_panel.js
> index
> d802ed4e9eb1b15cc8dd043f46efd10b0d994ab9..666f17e76a6827bbfb614d389cf87e4=
2cb3c8a1a
> 100644
> --- a/webkit/glue/devtools/js/heap_profiler_panel.js
> +++ b/webkit/glue/devtools/js/heap_profiler_panel.js
> @@ -34,6 +34,12 @@ WebInspector.HeapSnapshotView =3D function(parent, pro=
file)
> =A0 =A0 this.showCountDeltaAsPercent =3D true;
> =A0 =A0 this.showSizeDeltaAsPercent =3D true;
>
> + =A0 =A0this.categories =3D {
> + =A0 =A0 =A0 =A0code: new WebInspector.ResourceCategory("code",
> WebInspector.UIString("Code"), "rgb(255,121,0)"),
> + =A0 =A0 =A0 =A0data: new WebInspector.ResourceCategory("data",
> WebInspector.UIString("Objects and Data"), "rgb(47,102,236)"),
> + =A0 =A0 =A0 =A0other: new WebInspector.ResourceCategory("other",
> WebInspector.UIString("Other"), "rgb(186,186,186)")
> + =A0 =A0};
> +
> =A0 =A0 this.summaryBar =3D new WebInspector.SummaryBar(this.categories);
> =A0 =A0 this.summaryBar.element.id =3D "heap-snapshot-summary";
> =A0 =A0 this.summaryBar.calculator =3D new
> WebInspector.HeapSummaryCalculator(profile.used);
> @@ -72,11 +78,6 @@ WebInspector.HeapSnapshotView =3D function(parent, pro=
file)
>
> =A0WebInspector.HeapSnapshotView.prototype =3D {
>
> - =A0 =A0get categories()
> - =A0 =A0{
> - =A0 =A0 =A0 =A0return {code: {title: WebInspector.UIString("Code"), col=
or: {r:
> 255, g: 121, b: 0}}, data: {title: WebInspector.UIString("Objects and
> Data"), color: {r: 47, g: 102, b: 236}}, other: {title:
> WebInspector.UIString("Other"), color: {r: 186, g: 186, b: 186}}};
> - =A0 =A0},
> -
> =A0 =A0 get statusBarItems()
> =A0 =A0 {
> =A0 =A0 =A0 =A0 return [this.baseSelectElement, this.percentButton.elemen=
t];
>
>
>

Powered by Google App Engine
This is Rietveld 408576698