Issue 334019: Lazily create the find bar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 334019: Lazily create the find bar. (Closed)

Created:
11 years, 2 months ago by Ben Goodger (Google)

Modified:
9 years, 6 months ago

Reviewers:
Finnur

CC:
chromium-reviews_googlegroups.com, Paweł Hajdan Jr., ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Lazily create the find bar. http://crbug.com/21910 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30062 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30434

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -9 lines)			Patch
M	chrome/browser/automation/automation_provider.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/browser.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/browser.cc	View	1	4 chunks	+13 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Finnur

LGTM, one nit. Hmm... how come the try servers didn't run with this change?? http://codereview.chromium.org/334019/diff/1/4 ...

11 years, 1 month ago (2009-10-26 15:51:34 UTC) #2

Ben Goodger (Google)

11 years, 1 month ago (2009-10-26 17:59:54 UTC) #3

This is on my home machine. For some reason didn't work. I ran the UI tests
manually.

-Ben

On Mon, Oct 26, 2009 at 8:51 AM, <finnur@chromium.org> wrote:

> LGTM, one nit.
>
> Hmm... how come the try servers didn't run with this change??
>
>
> http://codereview.chromium.org/334019/diff/1/4
> File chrome/browser/browser.cc (right):
>
> http://codereview.chromium.org/334019/diff/1/4#newcode271
> Line 271: }
> nit: Extra line break can be removed.
>
>
> http://codereview.chromium.org/334019
>

Expand Messages | Collapse Messages