Issue 3336018: Send SIGTERM and SIGABRT signals to a process group

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3336018: Send SIGTERM and SIGABRT signals to a process group (Closed)

Created:
10 years, 3 months ago by Yusuke Sato

Modified:
9 years, 7 months ago

Reviewers:
Chris Masone

CC:
chromium-os-reviews_chromium.org, Zachary Kuznia, Peng, satorux1

Base URL:
ssh://git@chromiumos-git//login_manager.git

Visibility:
Public.

Description

Send SIGTERM and SIGABRT signals to a process group rather than a single process so the seesion manager could kill child processes of the Chrome browser process, such as ibus-daemon, ibus-memconf, ibus-engine-*, and candidate_window. BUG=chromium-os:6515 TEST=manually checked that session manager kills ibus-daemons. ran unittests by FEATURES="test" emerge-x86-generic chromeos-login

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -8 lines)			Patch
	M	session_manager_service.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	session_manager_unittest.cc	View		4 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Chris Masone

On 2010/09/10 07:14:22, Yusuke Sato wrote: > this change LGTM

10 years, 3 months ago (2010-09-10 18:38:07 UTC) #2

Yusuke Sato

10 years, 3 months ago (2010-09-13 08:42:07 UTC) #3

On 2010/09/10 18:38:07, Chris Masone wrote:
> On 2010/09/10 07:14:22, Yusuke Sato wrote:
> > 
> 
> this change LGTM

Sorry, I'll revert the change.
http://code.google.com/p/chromium-os/issues/detail?id=6515#c13

Expand Messages | Collapse Messages