Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Unified Diff: session_manager_unittest.cc

Issue 3336018: Send SIGTERM and SIGABRT signals to a process group (Closed) Base URL: ssh://git@chromiumos-git//login_manager.git
Patch Set: Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « session_manager_service.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: session_manager_unittest.cc
diff --git a/session_manager_unittest.cc b/session_manager_unittest.cc
index bc0ba22c39ed090530eb18a4a171671cc950d728..7c09f7b90162afc43c86595ed71b865960a7dfbd 100644
--- a/session_manager_unittest.cc
+++ b/session_manager_unittest.cc
@@ -347,7 +347,7 @@ TEST_F(SessionManagerTest, SessionNotStartedCleanupTest) {
manager_->test_api().set_child_pid(0, kDummyPid);
int timeout = 3;
- EXPECT_CALL(*(utils_.get()), kill(kDummyPid, SIGKILL))
+ EXPECT_CALL(*(utils_.get()), kill(-kDummyPid, SIGKILL))
.WillOnce(Return(0));
EXPECT_CALL(*(utils_.get()), ChildIsGone(kDummyPid, timeout))
.WillOnce(Return(true));
@@ -361,11 +361,11 @@ TEST_F(SessionManagerTest, SessionNotStartedSlowKillCleanupTest) {
manager_->test_api().set_child_pid(0, kDummyPid);
int timeout = 3;
- EXPECT_CALL(*(utils_.get()), kill(kDummyPid, SIGKILL))
+ EXPECT_CALL(*(utils_.get()), kill(-kDummyPid, SIGKILL))
.WillOnce(Return(0));
EXPECT_CALL(*(utils_.get()), ChildIsGone(kDummyPid, timeout))
.WillOnce(Return(false));
- EXPECT_CALL(*(utils_.get()), kill(kDummyPid, SIGABRT))
+ EXPECT_CALL(*(utils_.get()), kill(-kDummyPid, SIGABRT))
.WillOnce(Return(0));
MockUtils();
@@ -380,7 +380,7 @@ TEST_F(SessionManagerTest, SessionStartedCleanupTest) {
gchar email[] = "user@somewhere";
gchar nothing[] = "";
int timeout = 3;
- EXPECT_CALL(*(utils_.get()), kill(kDummyPid, SIGTERM))
+ EXPECT_CALL(*(utils_.get()), kill(-kDummyPid, SIGTERM))
.WillOnce(Return(0));
EXPECT_CALL(*(utils_.get()), ChildIsGone(kDummyPid, timeout))
.WillOnce(Return(true));
@@ -400,11 +400,11 @@ TEST_F(SessionManagerTest, SessionStartedSlowKillCleanupTest) {
test_api.set_child_pid(0, kDummyPid);
int timeout = 3;
- EXPECT_CALL(*(utils_.get()), kill(kDummyPid, SIGTERM))
+ EXPECT_CALL(*(utils_.get()), kill(-kDummyPid, SIGTERM))
.WillOnce(Return(0));
EXPECT_CALL(*(utils_.get()), ChildIsGone(kDummyPid, timeout))
.WillOnce(Return(false));
- EXPECT_CALL(*(utils_.get()), kill(kDummyPid, SIGABRT))
+ EXPECT_CALL(*(utils_.get()), kill(-kDummyPid, SIGABRT))
.WillOnce(Return(0));
MockUtils();
« no previous file with comments | « session_manager_service.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698