Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 3333012: Linux: Handle renderer and plugin crashes on a separate thread. (try 2)... (Closed)

Created:
10 years, 3 months ago by Lei Zhang
Modified:
9 years, 7 months ago
CC:
chromium-reviews, ben+cc_chromium.org
Visibility:
Public.

Description

Linux: Handle renderer and plugin crashes on a separate thread. (try 2) Also set retries / timeouts for wget to attempt to limit the duration of each crash handler. Move some code out of headers while we're at it. BUG=54071 TEST=change /usr/bin/wget to sleep forever, visit about:crash in a Breakpad-enabled build, make sure other renderers continue to work. Original Review URL: http://codereview.chromium.org/3308007 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58431

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -41 lines) Patch
M chrome/app/breakpad_linux.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/crash_handler_host_linux.h View 5 chunks +22 lines, -16 lines 0 comments Download
M chrome/browser/crash_handler_host_linux.cc View 6 chunks +84 lines, -23 lines 0 comments Download
M chrome/browser/crash_handler_host_linux_stub.cc View 2 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Lei Zhang
Whoops, I forgot to make this work without Breakpad. Added some trivial changes to crash_handler_host_linux_stub.cc ...
10 years, 3 months ago (2010-09-02 22:37:19 UTC) #1
willchan no longer on Chromium
10 years, 3 months ago (2010-09-02 22:51:19 UTC) #2
OK

Powered by Google App Engine
This is Rietveld 408576698