Linux: Handle renderer crashes on a separate thread....

Linux: Handle renderer and plugin crashes on a separate thread.

Also set retries / timeouts for wget to attempt to limit the duration of each crash handler. Move some code out of headers while we're at it.

BUG=54071
TEST=change /usr/bin/wget to sleep forever, visit about:crash in a Breakpad-enabled build, make sure other renderers continue to work.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58403

[willchan no longer on Chromium, 2010-09-02 21:00:06]

LGTM, thanks for the fix.  You might want to update the changelist dsecription
since it's not just renderer crashes (plugin too).

http://codereview.chromium.org/3308007/diff/4001/5002
File chrome/browser/crash_handler_host_linux.cc (right):

http://codereview.chromium.org/3308007/diff/4001/5002#newcode329
chrome/browser/crash_handler_host_linux.cc:329:
uploader_thread_->message_loop()->PostTask(FROM_HERE,
FROM_HERE should align with the next argument, so you should probably move
FROM_HERE to the next line.  I know lots of code does this wrong, but it's
against the style guide
(http://www.corp.google.com/eng/doc/cppguide.xml#Function_Calls).

[Lei Zhang, 2010-09-02 21:04:11]

On 2010/09/02 21:00:06, willchan wrote:
> LGTM, thanks for the fix.  You might want to update the changelist dsecription
> since it's not just renderer crashes (plugin too).
> 
> http://codereview.chromium.org/3308007/diff/4001/5002
> File chrome/browser/crash_handler_host_linux.cc (right):
> 
> http://codereview.chromium.org/3308007/diff/4001/5002#newcode329
> chrome/browser/crash_handler_host_linux.cc:329:
> uploader_thread_->message_loop()->PostTask(FROM_HERE,
> FROM_HERE should align with the next argument, so you should probably move
> FROM_HERE to the next line.  I know lots of code does this wrong, but it's
> against the style guide
> (http://www.corp.google.com/eng/doc/cppguide.xml#Function_Calls).

Done and done.

[agl, 2010-09-02 21:04:59]

LGTM

http://codereview.chromium.org/3308007/diff/4001/5002
File chrome/browser/crash_handler_host_linux.cc (right):

http://codereview.chromium.org/3308007/diff/4001/5002#newcode37
chrome/browser/crash_handler_host_linux.cc:37: // Handles the crash dump and
free the allocated BreakpadInfo struct.
s/free/frees/