Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 3332016: Add a confirmation prompt to app uninstallation on the ntp. (Closed)

Created:
10 years, 3 months ago by Aaron Boodman
Modified:
9 years, 6 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, Erik does not do reviews, arv (Not doing code reviews), pam+watch_chromium.org, ben+cc_chromium.org
Base URL:
git://codf21.jail/chromium.git
Visibility:
Public.

Description

Add a confirmation prompt to app uninstallation on the ntp. The uninstall dialog used to say: [===============================x] |Confirm Uninstallation | |--------------------------------| |<b>Uninstall Foo Extension?</b> | | | |Are you sure you want to | |uninstall this extension? | | | |================================| We don't have the bottom string with the word 'app', and I realized it is somewhat extraneous anyway. So just removed it in all cases and de-bolded the text above. Looks much better. Also, fixed a bug where the icon we display in the GTK dialogs is too big by doing image resizing in ExtensionInstallUI. BUG=54874 TEST=Uninstall app and extension. Both should have a prompt, and UI layout should be the same. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=59157

Patch Set 1 #

Patch Set 2 : fix layout on Windows, remove some old crap #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -125 lines) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/cocoa/extension_install_prompt.mm View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/dom_ui/app_launcher_handler.h View 4 chunks +19 lines, -0 lines 0 comments Download
M chrome/browser/dom_ui/app_launcher_handler.cc View 1 2 chunks +36 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_install_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_ui.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/gtk/extension_install_prompt_gtk.cc View 5 chunks +4 lines, -22 lines 0 comments Download
M chrome/browser/resources/ntp/apps.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/views/extensions/extension_install_prompt.cc View 1 6 chunks +33 lines, -86 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Aaron Boodman
10 years, 3 months ago (2010-09-09 07:35:52 UTC) #1
Matt Perry
LGTM
10 years, 3 months ago (2010-09-09 18:24:51 UTC) #2
Aaron Boodman
I had to do some touch-up on Windows to make the text label in the ...
10 years, 3 months ago (2010-09-10 20:20:56 UTC) #3
Matt Perry
10 years, 3 months ago (2010-09-10 20:37:47 UTC) #4
LGTM2

Powered by Google App Engine
This is Rietveld 408576698