Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(882)

Unified Diff: chrome/browser/extensions/extension_install_ui.cc

Issue 3332016: Add a confirmation prompt to app uninstallation on the ntp. (Closed) Base URL: git://codf21.jail/chromium.git
Patch Set: fix layout on Windows, remove some old crap Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_install_ui.cc
diff --git a/chrome/browser/extensions/extension_install_ui.cc b/chrome/browser/extensions/extension_install_ui.cc
index e2a8c8eac197b6b976cbb21267f7d0db0925f1fe..5e3936600c2742195f5b344e3319d26deee4e26c 100644
--- a/chrome/browser/extensions/extension_install_ui.cc
+++ b/chrome/browser/extensions/extension_install_ui.cc
@@ -63,6 +63,9 @@ const int ExtensionInstallUI::kButtonIds[NUM_PROMPT_TYPES] = {
namespace {
+// Size of extension icon in top left of dialog.
+const int kIconSize = 69;
+
static void GetV2Warnings(Extension* extension,
std::vector<string16>* warnings) {
if (!extension->plugins().empty()) {
@@ -291,15 +294,13 @@ void ExtensionInstallUI::OnImageLoaded(
std::vector<string16> warnings;
GetV2Warnings(extension_, &warnings);
- ShowExtensionInstallUIPrompt2Impl(
- profile_, delegate_, extension_, &icon_, warnings);
+ ShowExtensionInstallUIPrompt2Impl(profile_, delegate_, extension_, &icon_,
+ warnings);
break;
}
case UNINSTALL_PROMPT: {
- string16 message =
- l10n_util::GetStringUTF16(IDS_EXTENSION_UNINSTALL_CONFIRMATION);
ShowExtensionInstallUIPromptImpl(profile_, delegate_, extension_, &icon_,
- message, UNINSTALL_PROMPT);
+ UNINSTALL_PROMPT);
break;
}
default:
@@ -360,8 +361,7 @@ void ExtensionInstallUI::ShowConfirmation(PromptType prompt_type) {
ExtensionResource image =
extension_->GetIconResource(Extension::EXTENSION_ICON_LARGE);
tracker_.LoadImage(extension_, image,
- gfx::Size(Extension::EXTENSION_ICON_LARGE,
- Extension::EXTENSION_ICON_LARGE),
+ gfx::Size(kIconSize, kIconSize),
ImageLoadingTracker::DONT_CACHE);
}
« no previous file with comments | « chrome/browser/extensions/extension_install_ui.h ('k') | chrome/browser/gtk/extension_install_prompt_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698