Issue 333029: Remove the suppression for a Issue 24307: Data race on reference counter...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 333029: Remove the suppression for a Issue 24307: Data race on reference counter... (Closed)

Created:
11 years, 1 month ago by Nirnimesh

Modified:
9 years, 7 months ago

Reviewers:
Timur Iskhodzhanov, rvargas (doing something else), rvargas1

CC:
chromium-reviews_googlegroups.com, not_the_right_glider, Nirnimesh, dank, stuartmorgan, pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Remove the suppression for a Issue 24307: Data race on reference counter BUG=24307 TEST=tsan mac bot should remain green - (http://build.chromium.org/buildbot/waterfall/waterfall?builder=Linux+Tests+(tsan)&builder=Chromium+Mac+(tsan)) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30120

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -6 lines)			Patch
	M	tools/valgrind/tsan/suppressions.txt	View		1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Timur Iskhodzhanov

If possible, I'd like to review changes ThreadSanitizer suppressions as well. Currently, we run ThreadSanitizer ...

11 years, 1 month ago (2009-10-27 10:27:49 UTC) #3

not_the_right_dank

11 years, 1 month ago (2009-10-27 11:03:24 UTC) #4

Maybe that means you should have an FYI waterfall tsan bot set to the
strict settings...

On Tue, Oct 27, 2009 at 3:27 AM,  <timurrrr@chromium.org> wrote:
>
> If possible, I'd like to review changes ThreadSanitizer suppressions as
> well.
>
> Currently, we run ThreadSanitizer bots in the most conservative mode.
> That means: if the suppression is not used on the bots the race may still be
> present or the report may be flaky. Before removing TSAN suppressions I run
> them
> locally with the most agressive TSAN mode which finds much more data races
> (and
> its results are much more certain).
>
> As for this particular suppressions - yes, I don't see the report anymore in
> any
> ThreadSanitizer mode, LGTM.
>
> http://codereview.chromium.org/333029
>

Expand Messages | Collapse Messages