Fix compile on Snow Leopard.

Fix compile on Snow Leopard.

BUG=TEST=phajdan

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30012

[Mark Mentovai, 2009-10-24 18:46:21]

LGTM on the fix, but consider this...

http://codereview.chromium.org/333023/diff/1/2
File chrome/browser/cocoa/bookmark_bar_controller_unittest.mm (right):

http://codereview.chromium.org/333023/diff/1/2#newcode679
Line 679: std::wstring titles[] = {
Does this even need to be std::wstring?  You can make both of these arrays be
const char*[] and use base::SysUTF8ToNSString on each.  Or, as an alternative,
you can make each be an array of NSString*s.

[Nico, 2009-10-24 18:51:33]

http://codereview.chromium.org/333023/diff/1/2
File chrome/browser/cocoa/bookmark_bar_controller_unittest.mm (right):

http://codereview.chromium.org/333023/diff/1/2#newcode679
Line 679: std::wstring titles[] = {
On 2009/10/24 18:46:21, Mark Mentovai wrote:
> Does this even need to be std::wstring?  You can make both of these arrays be
> const char*[] and use base::SysUTF8ToNSString on each.  Or, as an alternative,
> you can make each be an array of NSString*s.

GetTitle() below returns a wstring, and the GURL constructor takes a char*, so
this seemed easiest…

I could use NSString arrays and then convert them to wstrings below when
comparing, but this being a test I wanted to make the reference data as close to
what I want the result be as possible.

It doesn't really matter, so I'll leave it as is.

[Mark Mentovai, 2009-10-24 18:53:36]

OK, cool, that sounds good.  Thanks for the zippy response.

Mark

Nico wrote:
> http://codereview.chromium.org/333023/diff/1/2
> File chrome/browser/cocoa/bookmark_bar_controller_unittest.mm (right):
>
> http://codereview.chromium.org/333023/diff/1/2#newcode679
> Line 679: std::wstring titles[] =3D {
> On 2009/10/24 18:46:21, Mark Mentovai wrote:
>>
>> Does this even need to be std::wstring? =A0You can make both of these
>
> arrays be
>>
>> const char*[] and use base::SysUTF8ToNSString on each. =A0Or, as an
>
> alternative,
>>
>> you can make each be an array of NSString*s.
>
> GetTitle() below returns a wstring, and the GURL constructor takes a
> char*, so this seemed easiest=85
>
> I could use NSString arrays and then convert them to wstrings below when
> comparing, but this being a test I wanted to make the reference data as
> close to what I want the result be as possible.
>
> It doesn't really matter, so I'll leave it as is.