Fix compile on Snow Leopard.

chrome/browser/cocoa/bookmark_bar_controller_unittest.mm

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/basictypes.h"
 #include "base/scoped_nsobject.h"
 #include "base/sys_string_conversions.h"
 #import "chrome/browser/cocoa/bookmark_bar_constants.h"
@@ skipping 658 matching lines @@
         [button frame].size.height);
   }
 }
 
 TEST_F(BookmarkBarControllerTest, DropBookmarks) {
   const char* urls[] = {
     "http://qwantz.com",
     "http://xkcd.com",
     "javascript:alert('lolwut')"
   };
   std::wstring titles[] = {

[Mark Mentovai, 2009/10/24 18:46:21]

Does this even need to be std::wstring?  You can make both of these arrays be
const char*[] and use base::SysUTF8ToNSString on each.  Or, as an alternative,
you can make each be an array of NSString*s.

[Nico, 2009/10/24 18:51:33]

GetTitle() below returns a wstring, and the GURL constructor takes a char*, so
this seemed easiest…

I could use NSString arrays and then convert them to wstrings below when
comparing, but this being a test I wanted to make the reference data as close to
what I want the result be as possible.

It doesn't really matter, so I'll leave it as is.

     std::wstring(L"Philosophoraptor"),
     std::wstring(L"Can't draw"),
     std::wstring(L"Inspiration")
   };
   EXPECT_EQ(arraysize(urls), arraysize(titles));
 
   NSMutableArray* nsurls = [NSMutableArray arrayWithCapacity:0];
   NSMutableArray* nstitles = [NSMutableArray arrayWithCapacity:0];
   for (size_t i = 0; i < arraysize(urls); ++i) {
-    [nsurls addObject:[NSString stringWithCString:urls[i]]];
+    [nsurls addObject:base::SysUTF8ToNSString(urls[i])];
     [nstitles addObject:base::SysWideToNSString(titles[i])];
   }
 
   BookmarkModel* model = helper_.profile()->GetBookmarkModel();
   const BookmarkNode* parent = model->GetBookmarkBarNode();
   [bar_ addURLs:nsurls withTitles:nstitles at:NSZeroPoint];
   EXPECT_EQ(3, parent->GetChildCount());
   for (int i = 0; i < parent->GetChildCount(); ++i) {
     EXPECT_EQ(parent->GetChild(i)->GetURL(), GURL(urls[i]));
     EXPECT_EQ(parent->GetChild(i)->GetTitle(), titles[i]);
   }
 }
 
 
 // Cannot test these methods since they simply call a single static
 // method, BookmarkEditor::Show(), which is impossible to mock.
 // editBookmark:, addPage:
 
 
 }  // namespace