Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2099)

Unified Diff: chrome/browser/sync/glue/extension_util_unittest.cc

Issue 3324012: Check for updates for a user script only if it has an update URL. (Closed)
Patch Set: Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/glue/extension_util.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/glue/extension_util_unittest.cc
diff --git a/chrome/browser/sync/glue/extension_util_unittest.cc b/chrome/browser/sync/glue/extension_util_unittest.cc
index 65b15c5e5459b005d331a9cae39102714aeaff1f..c710129c34b3794ea6e91892d4f5501485108d19 100644
--- a/chrome/browser/sync/glue/extension_util_unittest.cc
+++ b/chrome/browser/sync/glue/extension_util_unittest.cc
@@ -94,13 +94,20 @@ TEST_F(ExtensionUtilTest, IsSyncableExtension) {
{
FilePath file_path(kExtensionFilePath);
Extension extension(file_path);
- MakePossiblySyncableExtension(false, GURL(), GURL(), true,
+ MakePossiblySyncableExtension(false, GURL(kValidUpdateUrl1), GURL(), true,
Extension::INTERNAL, 0, &extension);
EXPECT_TRUE(IsExtensionSyncable(extension));
}
{
FilePath file_path(kExtensionFilePath);
Extension extension(file_path);
+ MakePossiblySyncableExtension(false, GURL(), GURL(), true,
+ Extension::INTERNAL, 0, &extension);
+ EXPECT_FALSE(IsExtensionSyncable(extension));
+ }
+ {
+ FilePath file_path(kExtensionFilePath);
+ Extension extension(file_path);
MakePossiblySyncableExtension(true, GURL(), GURL(), false,
Extension::INTERNAL, 0, &extension);
EXPECT_FALSE(IsExtensionSyncable(extension));
« no previous file with comments | « chrome/browser/sync/glue/extension_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698