Issue 3324007: Rename retcode to returncode to be consistent with subprocess.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3324007: Rename retcode to returncode to be consistent with subprocess. (Closed)

Created:
10 years, 3 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews, M-A Ruel

Visibility:
Public.

Description

Rename retcode to returncode to be consistent with subprocess. Change CheckCallError to inherit from Error. This will simplify try/except changes. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58695

Patch Set 1 #

Total comments: 1

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -14 lines)			Patch
M	gclient_utils.py	View	2 chunks	+10 lines, -10 lines	0 comments	Download
M	tests/fake_repos.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/gclient_utils_test.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trychange.py	View	1 chunk	+2 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

bradn

10 years, 3 months ago (2010-09-03 20:31:01 UTC) #2

Otherwise LTGM

http://codereview.chromium.org/3324007/diff/1/5
File trychange.py (right):

http://codereview.chromium.org/3324007/diff/1/5#newcode436
trychange.py:436: logging.warn(e.returncode)
Maybe a real message?

Expand Messages | Collapse Messages