Issue 3322013: Revert 58558 - [Mac] Move the reset of signal handlers to be very soon after ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3322013: Revert 58558 - [Mac] Move the reset of signal handlers to be very soon after ... (Closed)

Created:
10 years, 3 months ago by rohitrao (ping after 24h)

Modified:
9 years, 7 months ago

Reviewers:
rohitrao (ping after 24h)

CC:
chromium-reviews, pam+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 58558 - [Mac] Move the reset of signal handlers to be very soon after the fork, before we do any mach IPC. The MachPortSender constructor can sometimes hang forever (gets stuck in bootstrap_look_up()), so it is important to reset the child's signal handlers as early as possible. Nico would like me to mention that this was his idea. BUG=35374 TEST=If in the forever backwards spinner state, closing the tab should not quit the browser. TEST=In general, renderers and extensions and plugins should still work. Review URL: http://codereview.chromium.org/3302009 TBR=rohitrao@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58560

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -16 lines)			Patch
	M	base/process_util_posix.cc	View		3 chunks	+6 lines, -16 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages