Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 3302009: [Mac] Move the reset of signal handlers to be very soon after the fork, befor... (Closed)

Created:
10 years, 3 months ago by rohitrao (ping after 24h)
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai, Nico, agl
CC:
chromium-reviews, pam+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

[Mac] Move the reset of signal handlers to be very soon after the fork, before we do any mach IPC. The MachPortSender constructor can sometimes hang forever (gets stuck in bootstrap_look_up()), so it is important to reset the child's signal handlers as early as possible. Nico would like me to mention that this was his idea. BUG=35374 TEST=If in the forever backwards spinner state, closing the tab should not quit the browser. TEST=In general, renderers and extensions and plugins should still work. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58558

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M base/process_util_posix.cc View 1 3 chunks +16 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
rohitrao (ping after 24h)
Mark and Adam: is this change scary? The MachPortSender constructor can sometimes hang forever (gets ...
10 years, 3 months ago (2010-09-03 19:57:34 UTC) #1
Mark Mentovai
10 years, 3 months ago (2010-09-03 20:15:23 UTC) #2
LGTM in any event. Not scary.

http://codereview.chromium.org/3302009/diff/3001/4001
File base/process_util_posix.cc (right):

http://codereview.chromium.org/3302009/diff/3001/4001#newcode541
base/process_util_posix.cc:541: RestoreDefaultExceptionHandler();
Hmm. I wonder if we should move this too.

Powered by Google App Engine
This is Rietveld 408576698