Issue 332039: Add "remember my choice" checkbox for windows external protocol dialog....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 332039: Add "remember my choice" checkbox for windows external protocol dialog.... (Closed)

Created:
11 years, 1 month ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Miranda Callahan

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add "remember my choice" checkbox for windows external protocol dialog. BUG=24085 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30225

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -3 lines)			Patch
	M	chrome/browser/views/external_protocol_dialog.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/browser/views/external_protocol_dialog.cc	View		4 chunks	+24 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Miranda Callahan

11 years, 1 month ago (2009-10-27 03:38:57 UTC) #2

On 2009/10/27 01:31:40, Evan Stade wrote:
> 

LGTM, though it's too bad that DialogDelegate doesn't let one separate out the
cancel button from window closing.

Expand Messages | Collapse Messages