Add "remember my choice" checkbox for windows external protocol dialog....

chrome/browser/views/external_protocol_dialog.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/views/external_protocol_dialog.h"
 
 #include "app/l10n_util.h"
 #include "app/message_box_flags.h"
 #include "base/histogram.h"
 #include "base/registry.h"
@@ skipping 42 matching lines @@
 // ExternalProtocolDialog, views::DialogDelegate implementation:
 
 int ExternalProtocolDialog::GetDefaultDialogButton() const {
   return MessageBoxFlags::DIALOGBUTTON_CANCEL;
 }
 
 std::wstring ExternalProtocolDialog::GetDialogButtonLabel(
     MessageBoxFlags::DialogButton button) const {
   if (button == MessageBoxFlags::DIALOGBUTTON_OK)
     return l10n_util::GetString(IDS_EXTERNAL_PROTOCOL_OK_BUTTON_TEXT);
-
-  // Set the button to have a default name.
-  return L"";
+  else
+    return l10n_util::GetString(IDS_EXTERNAL_PROTOCOL_CANCEL_BUTTON_TEXT);
 }
 
 std::wstring ExternalProtocolDialog::GetWindowTitle() const {
   return l10n_util::GetString(IDS_EXTERNAL_PROTOCOL_TITLE);
 }
 
 void ExternalProtocolDialog::DeleteDelegate() {
   delete this;
 }
 
+bool ExternalProtocolDialog::Cancel() {
+  // We also get called back here if the user closes the dialog or presses
+  // escape. In these cases it would be preferable to ignore the state of the
+  // check box but MessageBox doesn't distinguish this from pressing the cancel
+  // button.
+  if (message_box_view_->IsCheckBoxSelected()) {
+    ExternalProtocolHandler::SetBlockState(
+        UTF8ToWide(url_.scheme()), ExternalProtocolHandler::BLOCK);
+  }
+
+  // Returning true closes the dialog.
+  return true;
+}
+
 bool ExternalProtocolDialog::Accept() {
   // We record how long it takes the user to accept an external protocol.  If
   // users start accepting these dialogs too quickly, we should worry about
   // clickjacking.
   UMA_HISTOGRAM_LONG_TIMES("clickjacking.launch_url",
                            base::Time::Now() - creation_time_);
 
+  if (message_box_view_->IsCheckBoxSelected()) {
+    ExternalProtocolHandler::SetBlockState(
+        UTF8ToWide(url_.scheme()), ExternalProtocolHandler::DONT_BLOCK);
+  }
+
   ExternalProtocolHandler::LaunchUrlWithoutSecurityCheck(url_);
   // Returning true closes the dialog.
   return true;
 }
 
 views::View* ExternalProtocolDialog::GetContentsView() {
   return message_box_view_;
 }
 
 ///////////////////////////////////////////////////////////////////////////////
@@ skipping 12 matching lines @@
 
   message_text += l10n_util::GetStringF(
       IDS_EXTERNAL_PROTOCOL_APPLICATION_TO_LAUNCH, command) + L"\n\n";
 
   message_text += l10n_util::GetString(IDS_EXTERNAL_PROTOCOL_WARNING);
 
   message_box_view_ = new MessageBoxView(MessageBoxFlags::kIsConfirmMessageBox,
                                          message_text,
                                          L"",
                                          kMessageWidth);
+  message_box_view_->SetCheckBoxLabel(
+      l10n_util::GetString(IDS_EXTERNAL_PROTOCOL_CHECKBOX_TEXT));
+
   HWND root_hwnd;
   if (tab_contents_) {
     root_hwnd = GetAncestor(tab_contents_->GetContentNativeView(), GA_ROOT);
   } else {
     // Dialog is top level if we don't have a tab_contents associated with us.
     root_hwnd = NULL;
   }
 
   views::Window::CreateChromeWindow(root_hwnd, gfx::Rect(), this)->Show();
 }
@@ skipping 11 matching lines @@
   std::wstring parameters = url_spec.substr(split_offset + 1,
                                             url_spec.length() - 1);
   std::wstring application_to_launch;
   if (cmd_key.ReadValue(NULL, &application_to_launch)) {
     ReplaceSubstringsAfterOffset(&application_to_launch, 0, L"%1", parameters);
     return application_to_launch;
   } else {
     return std::wstring();
   }
 }