Issue 332038: Fix memory leaks in media_bench.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 332038: Fix memory leaks in media_bench. (Closed)

Created:
11 years, 1 month ago by scherkus (not reviewing)

Modified:
9 years, 7 months ago

Reviewers:
fbarchard, awong

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Fix memory leaks in media_bench. BUG=25855, 25945 TEST=valgrind should report no leaks caused by media_bench itself Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30228

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -12 lines)			Patch
	M	media/bench/bench.cc	View	1	4 chunks	+19 lines, -12 lines	0 comments	Download

Total messages: 4 (0 generated)

scherkus (not reviewing)

build under linux, run media_bench with valgrind the command line I used was: valgrind --tool=memcheck ...

11 years, 1 month ago (2009-10-27 07:52:22 UTC) #3

fbarchard

11 years, 1 month ago (2009-10-27 18:12:29 UTC) #4

LGTM
fixes the leak.  would be good to do the command line one too.
valgrind is cool!