Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 332032: Fullscreen for ChromeOS (Closed)

Created:
11 years, 1 month ago by oshima
Modified:
9 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Fullscreen for ChromeOS with toolkit_views=1 build * show/hide chromeos components based on fullscreen status * added compact_navigation_bar_enabled_ flag to differentiate being in fullscreen and being disabled. BUG=22805 TEST=Toggle fullscreen mode using F11. Try with/without compact navigation bar, which can be enabled by "shift-ctrl-0". Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30119

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : some fix #

Patch Set 4 : comment fix #

Total comments: 2

Patch Set 5 : changes per review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -9 lines) Patch
M chrome/browser/chromeos/chromeos_browser_extenders.cc View 1 2 3 4 5 chunks +22 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
oshima
11 years, 1 month ago (2009-10-26 21:39:41 UTC) #1
sky
LGTM http://codereview.chromium.org/332032/diff/1004/1005 File chrome/browser/chromeos/chromeos_browser_extenders.cc (right): http://codereview.chromium.org/332032/diff/1004/1005#newcode47 Line 47: compact_navigation_bar_enabled_(FALSE) { nit: FALSE -> false
11 years, 1 month ago (2009-10-26 22:07:17 UTC) #2
oshima
11 years, 1 month ago (2009-10-26 22:40:27 UTC) #3
submitting.

http://codereview.chromium.org/332032/diff/1004/1005
File chrome/browser/chromeos/chromeos_browser_extenders.cc (right):

http://codereview.chromium.org/332032/diff/1004/1005#newcode47
Line 47: compact_navigation_bar_enabled_(FALSE) {
On 2009/10/26 22:07:18, sky wrote:
> nit: FALSE -> false

Done.

Powered by Google App Engine
This is Rietveld 408576698