Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1522)

Unified Diff: chrome/browser/chromeos/chromeos_browser_extenders.cc

Issue 332032: Fullscreen for ChromeOS (Closed)
Patch Set: changes per review Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/chromeos_browser_extenders.cc
diff --git a/chrome/browser/chromeos/chromeos_browser_extenders.cc b/chrome/browser/chromeos/chromeos_browser_extenders.cc
index fe63ec445f608f40079d78a62177a48e476003d8..e7c8fcd2e4fed006ab488ab70ed1c5aced1e2ca1 100644
--- a/chrome/browser/chromeos/chromeos_browser_extenders.cc
+++ b/chrome/browser/chromeos/chromeos_browser_extenders.cc
@@ -39,7 +39,12 @@ class NormalExtender : public BrowserExtender,
public:
explicit NormalExtender(BrowserView* browser_view)
: BrowserExtender(browser_view),
- main_menu_(NULL) {
+ main_menu_(NULL),
+ status_area_(NULL),
+ compact_navigation_bar_(NULL),
+ // CompactNavigationBar is disabled by default.
+ // TODO(oshima): Get this info from preference.
+ compact_navigation_bar_enabled_(false) {
}
virtual ~NormalExtender() {}
@@ -59,10 +64,6 @@ class NormalExtender : public BrowserExtender,
new CompactNavigationBar(browser_view()->browser());
browser_view()->AddChildView(compact_navigation_bar_);
compact_navigation_bar_->Init();
- // Disabled by default.
- // TODO(oshima): Get this info from preference.
- compact_navigation_bar_->SetVisible(false);
-
status_area_ = new StatusAreaView(
browser_view()->browser(),
browser_view()->GetWindow()->GetNativeWindow());
@@ -82,9 +83,18 @@ class NormalExtender : public BrowserExtender,
}
virtual gfx::Rect Layout(const gfx::Rect& bounds) {
- // skip if there is no space to layout.
- if (bounds.IsEmpty())
+ // Skip if there is no space to layout, or if the browser is in
+ // fullscreen mode.
+ if (bounds.IsEmpty() || browser_view()->IsFullscreen()) {
+ main_menu_->SetVisible(false);
+ compact_navigation_bar_->SetVisible(false);
+ status_area_->SetVisible(false);
return bounds;
+ } else {
+ main_menu_->SetVisible(true);
+ compact_navigation_bar_->SetVisible(compact_navigation_bar_enabled_);
+ status_area_->SetVisible(true);
+ }
// Layout main menu before tab strip.
gfx::Size main_menu_size = main_menu_->GetPreferredSize();
@@ -147,11 +157,11 @@ class NormalExtender : public BrowserExtender,
virtual void ActivationChanged() {}
virtual bool ShouldForceHideToolbar() {
- return compact_navigation_bar_->IsVisible();
+ return compact_navigation_bar_enabled_;
}
virtual void ToggleCompactNavigationBar() {
- compact_navigation_bar_->SetVisible(!compact_navigation_bar_->IsVisible());
+ compact_navigation_bar_enabled_ = !compact_navigation_bar_enabled_;
}
private:
@@ -193,6 +203,9 @@ class NormalExtender : public BrowserExtender,
// CompactNavigationBar view.
CompactNavigationBar* compact_navigation_bar_;
+ // A toggle flag to show/hide the compact navigation bar.
+ bool compact_navigation_bar_enabled_;
+
DISALLOW_COPY_AND_ASSIGN(NormalExtender);
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698