Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Issue 332022: GTK: Fix browser action bubble arrow positions. (Closed)

Created:
11 years, 2 months ago by Daniel Erat
Modified:
9 years, 7 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

GTK: Fix browser action bubble arrow positions. This also cleans up some of the InfoBubbleGtk code a bit. BUG=23373 TEST=tested LTR and RTL under metacity Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30088

Patch Set 1 #

Total comments: 1

Patch Set 2 : update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -70 lines) Patch
M chrome/browser/gtk/bookmark_bubble_gtk.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/gtk/extension_popup_gtk.cc View 2 chunks +11 lines, -1 line 0 comments Download
M chrome/browser/gtk/first_run_bubble.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/gtk/info_bubble_gtk.h View 5 chunks +25 lines, -20 lines 0 comments Download
M chrome/browser/gtk/info_bubble_gtk.cc View 1 10 chunks +49 lines, -49 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Daniel Erat
11 years, 2 months ago (2009-10-24 19:24:17 UTC) #1
Evan Stade
11 years, 1 month ago (2009-10-26 17:45:29 UTC) #2
looks good

http://codereview.chromium.org/332022/diff/1/5
File chrome/browser/gtk/info_bubble_gtk.cc (right):

http://codereview.chromium.org/332022/diff/1/5#newcode119
Line 119: UpdateArrowLocation(true);  // force move and reshape
nit: Comments should be in sentence format.

Powered by Google App Engine
This is Rietveld 408576698