GTK: Fix browser action bubble arrow positions.

chrome/browser/gtk/extension_popup_gtk.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/gtk/extension_popup_gtk.h"
 
 #include <gtk/gtk.h>
 
+#include "app/l10n_util.h"
 #include "chrome/browser/browser.h"
 #include "chrome/browser/browser_window.h"
 #include "chrome/browser/profile.h"
 #include "chrome/browser/extensions/extension_host.h"
 #include "chrome/browser/extensions/extension_process_manager.h"
 #include "chrome/browser/gtk/gtk_theme_provider.h"
 #include "chrome/common/notification_service.h"
 #include "googleurl/src/gurl.h"
 
 ExtensionPopupGtk::ExtensionPopupGtk(Browser* browser,
@@ skipping 34 matching lines @@
     NOTREACHED() << "Received unexpected notification";
   }
 }
 
 void ExtensionPopupGtk::ShowPopup() {
   if (bubble_) {
     NOTREACHED();
     return;
   }
 
+  // We'll be in the upper-right corner of the window for LTR languages, so we
+  // want to put the arrow at the upper-right corner of the bubble to match the
+  // page and app menus.
+  InfoBubbleGtk::ArrowLocationGtk arrow_location =
+      (l10n_util::GetTextDirection() == l10n_util::LEFT_TO_RIGHT) ?
+      InfoBubbleGtk::ARROW_LOCATION_TOP_RIGHT :
+      InfoBubbleGtk::ARROW_LOCATION_TOP_LEFT;
   bubble_ = InfoBubbleGtk::Show(browser_->window()->GetNativeHandle(),
-                                relative_to_, host_->view()->native_view(),
+                                relative_to_,
+                                host_->view()->native_view(),
+                                arrow_location,
                                 GtkThemeProvider::GetFrom(browser_->profile()),
                                 this);
 }
 
 void ExtensionPopupGtk::DestroyPopup() {
   if (!bubble_) {
     NOTREACHED();
     return;
   }
 
@@ skipping 11 matching lines @@
   ExtensionProcessManager* manager =
       browser->profile()->GetExtensionProcessManager();
   DCHECK(manager);
   if (!manager)
     return;
 
   ExtensionHost* host = manager->CreatePopup(url, browser);
   // This object will delete itself when the info bubble is closed.
   new ExtensionPopupGtk(browser, host, relative_to);
 }