Log the PLT to the log file. This is a convenience for...

Log the PLT to the log file.  This is a convenience for
debugging.

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30252

[jar (doing other things), 2009-10-27 19:31:58]

LGTM.  See nit below.

http://codereview.chromium.org/330030/diff/2002/3002
File chrome/renderer/render_view.cc (right):

http://codereview.chromium.org/330030/diff/2002/3002#newcode3586
Line 3586: LOG(INFO) << url.spec() << " PLT: " << (finish -
start).InMilliseconds();
nit: I'd suggest reordering to: PLT, then time, then spec.  It is always nice to
have the times easy to spot and compare with nearby loads when looking at a log,
and to have the "unknown length string" sitting at the end of the line.

[Mike Belshe, 2009-10-27 20:41:30]

http://codereview.chromium.org/330030/diff/2002/3002
File chrome/renderer/render_view.cc (right):

http://codereview.chromium.org/330030/diff/2002/3002#newcode3586
Line 3586: LOG(INFO) << url.spec() << " PLT: " << (finish -
start).InMilliseconds();
On 2009/10/27 19:31:58, jar wrote:
> nit: I'd suggest reordering to: PLT, then time, then spec.  It is always nice
to
> have the times easy to spot and compare with nearby loads when looking at a
log,
> and to have the "unknown length string" sitting at the end of the line.

Done.

[jar (doing other things), 2009-10-28 17:38:05]

Thanks!  Don't forget to upload ;-)

Jim

On Tue, Oct 27, 2009 at 1:41 PM,  <mbelshe@chromium.org> wrote:
>
> http://codereview.chromium.org/330030/diff/2002/3002
> File chrome/renderer/render_view.cc (right):
>
> http://codereview.chromium.org/330030/diff/2002/3002#newcode3586
> Line 3586: LOG(INFO) << url.spec() << " PLT: " << (finish -
> start).InMilliseconds();
> On 2009/10/27 19:31:58, jar wrote:
>>
>> nit: I'd suggest reordering to: PLT, then time, then spec.  It is
>
> always nice to
>>
>> have the times easy to spot and compare with nearby loads when looking
>
> at a log,
>>
>> and to have the "unknown length string" sitting at the end of the
>
> line.
>
> Done.
>
> http://codereview.chromium.org/330030
>