Change the download location NSPathControl to refuse first responder.

Change the download location NSPathControl to refuse first responder.

BUG=None
TEST=Preferences-->Under the Hood. Click on downloads path, don't get awkward blue focus ring.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30230

[pink (ping after 24hrs), 2009-10-27 13:56:22]

What if the user has the global a11y flag set to be able to tab through all UI
controls. Does it still refuse firstResponder in that case?

[pink (ping after 24hrs), 2009-10-27 13:57:04]

What if the user has the global a11y flag set to be able to tab through all UI
controls. Does it still refuse firstResponder in that case?

[Robert Sesek, 2009-10-27 16:32:08]

On 2009/10/27 13:57:04, pink wrote:
> What if the user has the global a11y flag set to be able to tab through all UI
> controls. Does it still refuse firstResponder in that case?

No, this will not take first responder with that flag. This is only the visual
representation of the path, though, not the button that changes it. If this is
important, then we can disregard this CL.

On a side note: It appears that even when the a11y flag is set, none of our
preference controls are tab-able.

[pink (ping after 24hrs), 2009-10-27 16:57:48]

Probably because we haven't set up the key loop correctly/at all. We
need to make a pass over all our dialogs and do this.

Why does that control default to allowing first responder if there's
nothing the user can do with it (in general)? Seems odd.

LGTM in any case, i guess.

On Tue, Oct 27, 2009 at 12:32 PM,  <rsesek@chromium.org> wrote:
> On 2009/10/27 13:57:04, pink wrote:
>>
>> What if the user has the global a11y flag set to be able to tab through
>> all UI
>> controls. Does it still refuse firstResponder in that case?
>
> No, this will not take first responder with that flag. This is only the
> visual
> representation of the path, though, not the button that changes it. If this
> is
> important, then we can disregard this CL.
>
> On a side note: It appears that even when the a11y flag is set, none of our
> preference controls are tab-able.
>
> http://codereview.chromium.org/330028
>



-- 
Mike Pinkerton
Mac Weenie
pinkerton@google.com

[Robert Sesek, 2009-10-27 17:53:53]

On 2009/10/27 16:57:48, pink wrote:
> Why does that control default to allowing first responder if there's
> nothing the user can do with it (in general)? Seems odd.
> 
> LGTM in any case, i guess.

NSPathControl has different styles, one of which is to have the individual path
segments be button cells. The style we use here, however, is just a visual path
representation.

[pink (ping after 24hrs), 2009-10-27 17:56:25]

gotcha, thanks for putting up with me.

On Tue, Oct 27, 2009 at 1:53 PM,  <rsesek@chromium.org> wrote:
> On 2009/10/27 16:57:48, pink wrote:
>>
>> Why does that control default to allowing first responder if there's
>> nothing the user can do with it (in general)? Seems odd.
>
>> LGTM in any case, i guess.
>
> NSPathControl has different styles, one of which is to have the individual
> path
> segments be button cells. The style we use here, however, is just a visual
> path
> representation.
>
> http://codereview.chromium.org/330028
>



-- 
Mike Pinkerton
Mac Weenie
pinkerton@google.com