Change the default workdir for drover.

Change the default workdir for drover.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29965

[laforge, 2009-10-23 22:26:53]

LGTM

Kind Regards,

Anthony Laforge
Technical Program Manager
Mountain View, CA


On Fri, Oct 23, 2009 at 3:24 PM, <nsylvain@chromium.org> wrote:

> Reviewers: laforge,
>
> Description:
> Change the default workdir for drover.
>
> Please review this at http://codereview.chromium.org/330008
>
> SVN Base: svn://chrome-svn.corp.google.com/chrome/trunk/tools/depot_tools/
>
> Affected files:
>  M     drover.py
>
>
> Index: drover.py
> ===================================================================
> --- drover.py   (revision 29936)
> +++ drover.py   (working copy)
> @@ -343,13 +343,20 @@
>   return answer
>
>  def main(options, args):
> +  revision = options.revert or options.merge
> +
> +  # Initialize some variables used below. They can be overwritten by
> +  # the drover.properties file.
>   BASE_URL = "svn://chrome-svn/chrome"
>   TRUNK_URL = BASE_URL + "/trunk/src"
>   BRANCH_URL = BASE_URL + "/branches/$branch/src"
> -  DEFAULT_WORKING = "working"
>   SKIP_CHECK_WORKING = True
>   PROMPT_FOR_AUTHOR = False
>
> +  DEFAULT_WORKING = "drover_" + str(revision)
> +  if options.branch:
> +    DEFAULT_WORKING += ("_" + options.branch)
> +
>   # Override the default properties if there is a drover.properties file.
>   global file_pattern_
>   if os.path.exists("drover.properties"):
> @@ -359,8 +366,6 @@
>     if FILE_PATTERN:
>       file_pattern_ = FILE_PATTERN
>
> -  revision = options.revert or options.merge
> -
>   if options.revert and options.branch:
>     url = BRANCH_URL.replace("$branch", options.branch)
>   else:
>
>
>