Issue 3291022: [gcc] Fix addsi patterns for nacl64 PIC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3291022: [gcc] Fix addsi patterns for nacl64 PIC (Closed)

Created:
10 years, 3 months ago by eaeltsin

Modified:
9 years, 7 months ago

Reviewers:
khim, pasko-google - do not use

CC:
native-client-reviews_googlegroups.com

Base URL:
ssh://git@gitrw.chromium.org:9222/nacl-toolchain.git

Visibility:
Public.

Description

[gcc] Fix addsi patterns for nacl64 PIC This is similar to a bunch of previous fixes: prevent define_expands and define_insns from treating ILP32 PIC symbol_ref as an immediate. BUG=http://code.google.com/p/nativeclient/issues/detail?id=872 TEST=

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -9 lines)			Patch
	M	gcc/gcc/config/i386/i386.md	View		9 chunks	+9 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

pasko-google - do not use

10 years, 3 months ago (2010-09-09 15:01:23 UTC) #2

LGTM

though it's not easy to thoroughly review this :)

Expand Messages | Collapse Messages