Sending try jobs to linux_view is a strong signal that we should also send th...

Sending try jobs to linux_view is a strong signal that we should also send the try jobs to linux_chromeos, and vice versa.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58294

[Nicolas Sylvain, 2010-09-02 00:41:51]

lgtm

On Wed, Sep 1, 2010 at 4:35 PM, <thestig@chromium.org> wrote:

> Reviewers: Marc-Antoine Ruel, Nicolas Sylvain,
>
> Description:
> Sending try jobs to linux_view is a strong signal that we should also send
> the
> try jobs to linux_chromeos, and vice versa.
>
> BUG=none
> TEST=none
>
> Please review this at http://codereview.chromium.org/3291005/show
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/chromeos/PRESUBMIT.py
>  M     chrome/browser/views/PRESUBMIT.py
>  M     views/PRESUBMIT.py
>
>
> Index: chrome/browser/chromeos/PRESUBMIT.py
> ===================================================================
> --- chrome/browser/chromeos/PRESUBMIT.py        (revision 58254)
> +++ chrome/browser/chromeos/PRESUBMIT.py        (working copy)
> @@ -1,4 +1,4 @@
> -# Copyright (c) 2009 The Chromium Authors. All rights reserved.
> +# Copyright (c) 2010 The Chromium Authors. All rights reserved.
>  # Use of this source code is governed by a BSD-style license that can be
>  # found in the LICENSE file.
>
> @@ -9,4 +9,4 @@
>  """
>
>  def GetPreferredTrySlaves():
> -  return ['linux_chromeos']
> +  return ['linux_view', 'linux_chromeos']
> Index: chrome/browser/views/PRESUBMIT.py
> ===================================================================
> --- chrome/browser/views/PRESUBMIT.py   (revision 58254)
> +++ chrome/browser/views/PRESUBMIT.py   (working copy)
> @@ -1,5 +1,5 @@
>  #!/usr/bin/python
> -# Copyright (c) 2009 The Chromium Authors. All rights reserved.
> +# Copyright (c) 2010 The Chromium Authors. All rights reserved.
>  # Use of this source code is governed by a BSD-style license that can be
>  # found in the LICENSE file.
>
> @@ -10,4 +10,4 @@
>  """
>
>  def GetPreferredTrySlaves():
> -  return ['linux_view']
> +  return ['linux_view', 'linux_chromeos']
> Index: views/PRESUBMIT.py
> ===================================================================
> --- views/PRESUBMIT.py  (revision 58254)
> +++ views/PRESUBMIT.py  (working copy)
> @@ -1,5 +1,5 @@
>  #!/usr/bin/python
> -# Copyright (c) 2009 The Chromium Authors. All rights reserved.
> +# Copyright (c) 2010 The Chromium Authors. All rights reserved.
>  # Use of this source code is governed by a BSD-style license that can be
>  # found in the LICENSE file.
>
> @@ -10,4 +10,4 @@
>  """
>
>  def GetPreferredTrySlaves():
> -  return ['linux_view']
> +  return ['linux_view', 'linux_chromeos']
>
>
>

[M-A Ruel, 2010-09-02 01:25:04]

I can add more slaves to each builder if utilisation goes up significantly but
linux will always preempt them.

lgtm