Splits the command buffers into common commands...

Splits the command buffers into common commands
and specific commands.

Common are things like Noop, SetToken, Jump, Gosub, return.

Specific are O3D etc...


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30365

[gman, 2009-10-28 02:31:16]

PS: the renderer=cb cb_service=gl build currently fails unit_tests. This is
before this CL. We are working on a fix. The issue is something about
initialization where glewInit is called twice, the first time it gets GL version
3.0.0, the second time 1.1.0 and therefore fails when checking for features.

[apatrick, 2009-10-28 16:44:01]

LGTM

http://codereview.chromium.org/329046/diff/2030/2039
File command_buffer/common/cross/cmd_buffer_common.cc (right):

http://codereview.chromium.org/329046/diff/2030/2039#newcode52
Line 52: return (static_cast<int>(id) >= 0 && static_cast<int>(id) <
kNumCommands) ?
id is already int. no need for static_casts.

http://codereview.chromium.org/329046/diff/2030/2041
File command_buffer/common/cross/o3d_cmd_format.cc (right):

http://codereview.chromium.org/329046/diff/2030/2041#newcode54
Line 54: return (static_cast<int>(id) > kStartPoint &&
no need for static_casts.

http://codereview.chromium.org/329046/diff/2030/2033
File command_buffer/service/cross/common_decoder.cc (right):

http://codereview.chromium.org/329046/diff/2030/2033#newcode48
Line 48: return static_cast<char *>(shm_addr) + offset;
char -> int8