Add a command-line option for specifying a particular build to test and for p...

Add a command-line option for specifying a particular build to test and for permitting the tests to be run regardless of the underlying platform. Also some minor fixes and cleanup.
BUG=none
TEST=none
Original review at: http://codereview.chromium.org/269016

[kkania, 2009-10-27 17:04:07]

Accidentally aborted tests when running vista with exit code 1 instead of 0. 
Fixed.

[kuchhal, 2009-10-27 18:57:09]

Why did you move to this new issue instead of just using issue 269016? This
being new made it harder to see what changed in the most recent upload.

http://codereview.chromium.org/329037/diff/1/3
File chrome/test/mini_installer_test/test.cc (right):

http://codereview.chromium.org/329037/diff/1/3#newcode30
Line 30: static void CleanTheSystem() {
why static?

http://codereview.chromium.org/329037/diff/1/3#newcode65
Line 65: static void TearDownTestCase() {
Why static and why TearDownTestCase and not just TearDown?

[kkania, 2009-10-27 19:45:01]

http://codereview.chromium.org/329037/diff/1/3
File chrome/test/mini_installer_test/test.cc (right):

http://codereview.chromium.org/329037/diff/1/3#newcode65
Line 65: static void TearDownTestCase() {
On 2009/10/27 18:57:09, kuchhal wrote:
> Why static and why TearDownTestCase and not just TearDown?

CleanTheSystem is called in SetUp already. I use TearDownTestCase because I
wanted to do a final uninstall of Chromium after all these tests have finished.
If I changed it to TearDown, CleanTheSystem would be run twice between all
tests.

[kuchhal, 2009-10-28 18:44:11]

ok .lgtm.

On Tue, Oct 27, 2009 at 12:45 PM, <kkania@chromium.org> wrote:

>
> http://codereview.chromium.org/329037/diff/1/3
> File chrome/test/mini_installer_test/test.cc (right):
>
> http://codereview.chromium.org/329037/diff/1/3#newcode65
> Line 65: static void TearDownTestCase() {
> On 2009/10/27 18:57:09, kuchhal wrote:
>
>> Why static and why TearDownTestCase and not just TearDown?
>>
>
> CleanTheSystem is called in SetUp already. I use TearDownTestCase
> because I wanted to do a final uninstall of Chromium after all these
> tests have finished. If I changed it to TearDown, CleanTheSystem would
> be run twice between all tests.
>
>
> http://codereview.chromium.org/329037
>