Issue 329031: CL which includes http://codereview.chromium.org/337006 for mrossetti...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 329031: CL which includes http://codereview.chromium.org/337006 for mrossetti... (Closed)

Created:
11 years, 1 month ago by John Grabowski

Modified:
9 years, 6 months ago

Reviewers:
mrossetti

CC:
chromium-reviews_googlegroups.com, John Grabowski, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

CL which includes http://codereview.chromium.org/337006 for mrossetti Also includes a unit test fix. BUG=21908 TEST=Control-click on the bookmark bar, either on an existing folder or on the blank area and choose "Add Folder..." from the contextual menu. A sheet will drop down from the bookmark bar asking for the name of the folder to add. The edit field will be populated with the proposed name 'New folder'. ('New folder' will be appropriately localized.) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30207

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -12 lines)			Patch
	M	chrome/browser/cocoa/bookmark_name_folder_controller.mm	View		2 chunks	+5 lines, -11 lines	0 comments	Download
	M	chrome/browser/cocoa/bookmark_name_folder_controller_unittest.mm	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages