Issue 337006: New Folder Should Show Up as "New Folder"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 337006: New Folder Should Show Up as "New Folder" (Closed)

Created:
11 years, 2 months ago by mrossetti

Modified:
9 years, 7 months ago

Reviewers:
John Grabowski

CC:
chromium-reviews_googlegroups.com, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Pull localized 'new folder' name and set that into the edit text field. BUG=21908 TEST=Control-click on the bookmark bar, either on an existing folder or on the blank area and choose "Add Folder..." from the contextual menu. A sheet will drop down from the bookmark bar asking for the name of the folder to add. The edit field will be populated with the proposed name 'New folder'. ('New folder' will be appropriately localized.)

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -11 lines)			Patch
	M	chrome/browser/cocoa/bookmark_name_folder_controller.mm	View		2 chunks	+5 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

John Grabowski

11 years, 1 month ago (2009-10-27 00:16:26 UTC) #3

On 2009/10/23 21:37:07, John Grabowski wrote:
> LGTM

Landed as revision 30136

Expand Messages | Collapse Messages